Skip to content

Update index for extension ip-group#1034

Merged
haroldrandom merged 5 commits intoAzure:masterfrom
haroldrandom:issue_10726_update_index
Oct 30, 2019
Merged

Update index for extension ip-group#1034
haroldrandom merged 5 commits intoAzure:masterfrom
haroldrandom:issue_10726_update_index

Conversation

@haroldrandom
Copy link
Contributor

@haroldrandom haroldrandom commented Oct 30, 2019 •
edited
Loading

Updating index for extension ip-group for azure-cli feature requested in 10726

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

@azuresdkci
Copy link

azuresdkci commented Oct 30, 2019

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/haroldrandom/azure-cli-extensions.git@issue_10726_update_index#subdirectory=src/$EXT&egg=$EXT"

@haroldrandom haroldrandom force-pushed the issue_10726_update_index branch from 4c60fb2 to 392e79c Compare October 30, 2019 07:50
@haroldrandom haroldrandom reopened this Oct 30, 2019
@azuresdkci
Copy link

azuresdkci commented Oct 30, 2019

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/haroldrandom/azure-cli-extensions.git@issue_10726_update_index#subdirectory=src/$EXT&egg=$EXT"

Fix a bug that failed CI
7451a0c 
- Correct the wrongly imported ResourceType of IpGroups
@haroldrandom haroldrandom mentioned this pull request Oct 30, 2019
Closed
@haroldrandom haroldrandom self-assigned this Oct 30, 2019
@haroldrandom haroldrandom reopened this Oct 30, 2019
@azuresdkci
Copy link

azuresdkci commented Oct 30, 2019

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/haroldrandom/azure-cli-extensions.git@issue_10726_update_index#subdirectory=src/$EXT&egg=$EXT"

@haroldrandom haroldrandom merged commit 20e4dd6 into Azure:master Oct 30, 2019
@haroldrandom haroldrandom deleted the issue_10726_update_index branch October 30, 2019 12:10
ManuInNZ pushed a commit to ManuInNZ/azure-cli-extensions that referenced this pull request Apr 11, 2020
@ManuInNZ
Update index.json for extension ip-group (Azure#1034)
eed4b47 
* Update index for extension ip-group

* Fix a bug that failed CI

* Correct the wrongly imported ResourceType of IpGroups

* Update index.json

* Fix a bug that failed CI and update index.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zikalino zikalino Awaiting requested review from zikalino

1 more reviewer

@mmyyrroonn mmyyrroonn mmyyrroonn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@haroldrandom haroldrandom

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@haroldrandom @azuresdkci @mmyyrroonn